Repository navigation
Fix SonarCloud coverage report glob pattern and update devDependencies - #95
Merged
Merged
Conversation
SonarCloud reports zero code coverage for this repo. This project uses xunit.v3 4.0.0, which only runs under the Microsoft.Testing.Platform (MTP) 'dotnet test' mode, so the test projects correctly use coverlet.MTP (the VSTest-only coverlet.collector doesn't work under MTP). However, coverlet.MTP names its output file coverage.opencover.<numeric-session-id>.xml, whereas the workflow's Sonar scanner argument used the glob **/*.opencover.xml, which only matches filenames literally ending in "opencover.xml" - the session-ID segment breaks that match, so the scanner silently found no coverage report to ingest. Verified locally: `dotnet test --coverlet --coverlet-output-format opencover` (matching CI) produces files such as coverage.opencover.280826202345868.xml across both test projects (DemaConsulting.ReviewMark.Tests and OtsSoftwareTests), which the corrected glob **/coverage.opencover.*.xml matches but the old glob did not. All 867 tests still pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Updates direct npm devDependencies to their latest published versions: @mermaid-js/mermaid-cli 11.12.0 -> 11.16.0, cspell 9.7.0 -> 10.1.1, markdownlint-cli2 0.21.0 -> 0.23.2 (mermaid-filter already at latest 1.4.7). Remaining npm audit findings are transitive dependencies pulled in via mermaid-cli/mermaid-filter's puppeteer dependency, with no fix currently available upstream - out of scope per user request. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates CI SonarCloud coverage ingestion and bumps Node-based development tooling versions used for linting/docs generation within the ReviewMark repository.
Changes:
- Adjust SonarCloud OpenCover report path glob in the build workflow.
- Upgrade devDependencies:
@mermaid-js/mermaid-cli,cspell, andmarkdownlint-cli2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
package.json |
Updates devDependency versions for documentation and lint tooling. |
.github/workflows/build.yaml |
Tweaks SonarCloud OpenCover reports path glob used during CI analysis. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 19, 2026
This was referenced Oct 26, 2026
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to both the build workflow and development dependencies. The most notable changes are an adjustment to the SonarCloud OpenCover report path in the CI workflow and upgrades to several devDependencies in
package.json.Build workflow update:
.github/workflows/build.yamlto match files namedcoverage.opencover.*.xmlinstead of any.opencover.xmlfile.Development dependency upgrades:
@mermaid-js/mermaid-clifrom version 11.12.0 to 11.16.0.cspellfrom version 9.7.0 to 10.1.1.markdownlint-cli2from version 0.21.0 to 0.23.2.