fix(cpuraster): migrate example for ADR-0039 core/nodes namespaces#28
Merged
Conversation
The out-of-SDK CPU rasterizer predates ADR-0039 (last touched at Initial release) and is not in CI, so the namespace move (core types -> x3d::core, node types -> x3d::nodes) silently broke its build: SFImage/SFColor in Texture.hpp/SceneRender.hpp, X3DNode/MFString in main.cpp. Add the missing 'using namespace' directives per translation unit; also fix a -Wmisleading- indentation -Werror in text_render_test.cpp. mise run cpuraster now passes (11/11). Unblocks the headless renderer + the demos task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The out-of-SDK CPU rasterizer example predates ADR-0039 and is not covered by
mise run ci, so the namespace move (core types →x3d::core, node types →x3d::nodes) silently broke its build:SFImage/SFColorunqualified incpuraster/Texture.hppandcpuraster/SceneRender.hppX3DNode/MFStringunqualified inmain.cppFix: add the missing
using namespace x3d::core;/x3d::nodes;per translation unit. Also fixes a-Wmisleading-indentation-Werrorintext_render_test.cpp.mise run cpurasternow passes (11/11). Unblocks the headless renderer and thedemostask. Pure example-side fix; no SDK/runtime changes.