Repository navigation
[Spark] Enable async AMT CommitInfo reads with checksum gating - #7907
Open
yumingxuanguo-db wants to merge 2 commits into
Open
yumingxuanguo-db wants to merge 2 commits into
yumingxuanguo-db wants to merge 2 commits into
Conversation
Signed-off-by: Yumingxuan Guo <171533467+yumingxuanguo-db@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
AMT snapshot discovery can miss file actions when CRCs are unavailable and asynchronous CommitInfo reads are disabled. Enable this fallback by default so discovery can obtain the last manifest commit reference from CommitInfo.
Pass the supplied checksum into the async-read decision and skip the read when it is already available. Reads still require checkpoint reconciliation and the feature flag. Record
delta.amt.snapshotDiscovery.readLastCommitInfoAsyncafter each completed read, including its duration and version, and add anamtSupportedhelper for protocol capability checks.How was this patch tested?
Adds tests in
AMTSnapshotDiscoverySuitefor cold and warm AMT reads emitting the async-read event, and for post-commit snapshots skipping the read when an incremental checksum is supplied. The latter test keeps the table checkpoint-free so checkpoint reconciliation remains enabled.git diff --checkand patch-integrity checks pass. Scala tests have not been run locally for this revision; CI validation is pending.Does this PR introduce any user-facing changes?
Enables the async CommitInfo fallback by default for AMT discovery without CRCs. Snapshot creation without a supplied checksum may incur an additional CommitInfo read; supplying a checksum avoids it. No public API or table-format changes.