Repository navigation
[Build] Rebalance Spark test shards with fresh suite durations - #7867
Open
timothyw553 wants to merge 2 commits into
Open
timothyw553 wants to merge 2 commits into
timothyw553 wants to merge 2 commits into
Conversation
Refresh project/test-durations.csv from the last 12 master runs. Many suites in the old list were renamed, so the heaviest current suites were hash-assigned and shards ranged from ~65 to ~150 minutes. Also make collect_test_durations.py use completed runs and skip failed shard jobs instead of requiring a successful run (master runs are currently marked failed even when all shards pass), and print the average for AVG_TEST_SUITE_DURATION_EXCLUDING_TOP_N. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Timothy Wang <timothy.art@gmail.com>
Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Timothy Wang <timothy.art@gmail.com>
Collaborator
Author
|
this was a failed experiment... shard 7 on Spark 4.1 and 4.2 run for 3 hours |
1 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Follow-up to #6069. Regenerate
project/test-durations.csvfrom the last 12 master runs.Spark test shards are unbalanced right now: in the same run, shards take ~65 to ~150 min. Only 40 of the 100 suites in the old CSV are still in the current top 100. Many were renamed (e.g.
generatedsuites.*subpackages, CatalogOwned -> CatalogManaged), so the slowest suites today (up to ~35 min) get hash-assigned instead of balanced.How was this patch tested?
CI on this PR will show the new shard times.
Does this PR introduce any user-facing changes?
No.
This pull request and its description were written by Isaac.