Repository navigation
[SPARK] Add new expressions to AllowedExpressionAllowlist - #7634
Merged
murali-db merged 3 commits intoSep 9, 2026
Merged
Conversation
johanl-db
approved these changes
Sep 9, 2026
1 of 5 tasks
murali-db
approved these changes
Sep 9, 2026
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
NULLIFis already allowed in Delta generated columns and check constraints. In Spark 4.2, its analyzed replacement contains With, CommonExpressionDef, CommonExpressionRef, and TypedNullLiteral. Delta validates the completely analyzed expression tree, but these internal expressions were missing from its allowlist. Consequently, valid uses ofNULLIFcould fail validation, including when OPTIMIZE revalidates a table's generated columns.This PR introduces Spark version specific expression allowlist shims. The Spark 4.0-4.1 shim adds no expressions, while the Spark 4.2 shim adds the internal NULLIF expansion expressions and
TimestampAddInterval. A Boolean shim method also lets the existing TimestampAddInterval test cancel on Spark versions where that expression is not allowlisted.How was this patch tested?
UTs
Does this PR introduce any user-facing changes?
No