Repository navigation
[delta][refactor-only] DeltaTableV2 Improvements - #5256
Merged
Merged
Conversation
added 3 commits
September 25, 2025 20:46
philipzhux
commented
Sep 25, 2025
|
|
||
| def apply(spark: SparkSession, tableDir: File, clock: Clock): DeltaTableV2 = { | ||
| val tablePath = new Path(tableDir.getAbsolutePath) | ||
| new DeltaTableV2(spark, tablePath, catalogTable = None, None, None, Map.empty) { |
Contributor
Author
There was a problem hiding this comment.
Note to reviewers: Changes needed because we make DTv2 default ctor private.
philipzhux
changed the title
kamcheungting-db
approved these changes
Sep 25, 2025
weiluo-db
approved these changes
Sep 30, 2025
huashi-st
pushed a commit
to huashi-st/delta
that referenced
this pull request
Apr 24, 2026
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> 1. Correctly, the apply function is the only valid code path to construct a DeltaTableV2. To avoid undefined behaviors, we make the default ctor of the DeltaTableV2 private. The only usage of the default ctor elsewhere is to provide a custom clock into the delta log, which we now make a custom helper function to cover that purpose. 2. A test-only change. In the vacuum suite, the delta log cache was cleared and delta log was accessed to make sure it was created with the manual testing clock. We want to move this before the construction of DeltaTableV2 to make sure it covers the delta log in DeltaTableV2. 3. Minor redirect fix. Currently, the redirect code in `DeltaTableV2.apply` calls `deltaTable.copy` regardless of whether there is redirection or not. A small refactor is done to avoid the cost of copying when there is no redirections. ## How was this patch tested? Existing UTs. <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. --> No --------- Co-authored-by: Philip Zhu <philip.zhu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
DeltaTableV2.applycallsdeltaTable.copyregardless of whether there is redirection or not. A small refactor is done to avoid the cost of copying when there is no redirections.How was this patch tested?
Existing UTs.
Does this PR introduce any user-facing changes?
No