Repository navigation
[Kernel] Update SchemaUtils validation to allow for variant - #5223
Merged
OussamaSaoudi merged 4 commits intoSep 25, 2025
Merged
Conversation
vkorukanti
suggested changes
Sep 17, 2025
| validateColumnNames(schema, isColumnMappingEnabled); | ||
| validateSupportedType(schema); | ||
| checkArgument(features != null, "Table features should not be null"); | ||
| validateColumnNames(schema, features.contains(TableFeatures.COLUMN_MAPPING_RW_FEATURE)); |
Contributor
There was a problem hiding this comment.
The COLUMN_MAPPING_RW_FEATURE doesn't necessarily imply column mapping is enabled in theory, this value should really come from the metadata configuration.
amogh-jahagirdar
force-pushed
the
variant-schema-evolution
branch
5 times, most recently
from
September 24, 2025 01:14
c047727 to
578720f
Compare
amogh-jahagirdar
changed the title
…en't any examples for that at the moment
…ports variant write
amogh-jahagirdar
force-pushed
the
variant-schema-evolution
branch
from
September 24, 2025 19:43
2ec41cb to
304682c
Compare
allisonport-db
left a comment
allisonport-db
left a comment
Contributor
There was a problem hiding this comment.
Just 1 request then LGTM
| } | ||
| } | ||
|
|
||
| test("create table - provide unsupported column types - expect failure") { |
Contributor
There was a problem hiding this comment.
Minor: Could we maybe create a custom data type FooType extends DataType and keep this test?
Contributor
There was a problem hiding this comment.
To be specific, just create this custom data type just within this test here
Collaborator
Author
There was a problem hiding this comment.
Sure that's reasonable just to make sure we have the right error message
Collaborator
Author
There was a problem hiding this comment.
Discussed offline, will take this in a follow on right after this
Contributor
There was a problem hiding this comment.
yeah, also with this change, I think we never hit that error message at all since all types are now supported!
allisonport-db
approved these changes
Sep 24, 2025
allisonport-db
left a comment
allisonport-db
left a comment
Contributor
There was a problem hiding this comment.
LGTM with the test-related request addressed in follow-up
huashi-st
pushed a commit
to huashi-st/delta
that referenced
this pull request
Apr 24, 2026
…#5223) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> This change allows variant in SchemaUtils validateSchema/validateUpdatedSchema ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> Added unit tests to SchemaUtilsSuite ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This change allows variant in SchemaUtils validateSchema/validateUpdatedSchema
How was this patch tested?
Added unit tests to SchemaUtilsSuite
Does this PR introduce any user-facing changes?