Repository navigation
[Test-only][Kernel] Refactor LogReplayEngineMetric suites to run using new and old snapshot APIs - #5217
Merged
allisonport-db merged 1 commit intoSep 17, 2025
Conversation
allisonport-db
commented
Sep 17, 2025
| ///////////////////////// | ||
|
|
||
| // Abstract method to be implemented by concrete test classes | ||
| protected def loadSnapshotFieldsCheckMetrics( |
Contributor
Author
There was a problem hiding this comment.
this was just overriden to largely be loadPandMCheckMetrics so removed it and let child suites override that instead if needed
allisonport-db
commented
Sep 17, 2025
| * The goal is to test the behavior of calls to `readJsonFiles` and `readParquetFiles` that | ||
| * Kernel makes. This calls determine the performance. | ||
| */ | ||
| class LogReplayEngineMetricsSuite extends LogReplayBaseSuite with BeforeAndAfterAll { |
Contributor
Author
There was a problem hiding this comment.
Below code moved below, this git diff is calculated confusingly
allisonport-db
commented
Sep 17, 2025
| // Test Helper Methods // | ||
| ///////////////////////// | ||
|
|
||
| def loadScanFilesCheckMetrics( |
Contributor
Author
There was a problem hiding this comment.
Same thing here, this method was moved below. LegacyLogReplayEngineMetricsSuite has a custom loadPandMCheckMetricsForTable which is a new method
allisonport-db
commented
Sep 17, 2025
| /////////// | ||
| expChecksumReadSet = expChecksumReadSet) | ||
|
|
||
| test("no hint, no checkpoint, reads all files") { |
Contributor
Author
There was a problem hiding this comment.
these tests are all just below in the abstract suite
|
|
||
| // SnapshotHint tests only apply for the legacy APIs since in the new APIs there is no persistent | ||
| // Table instance | ||
| test("read domain metadata fro checksum even if snapshot hint exists") { |
scottsand-db
approved these changes
Sep 17, 2025
huashi-st
pushed a commit
to huashi-st/delta
that referenced
this pull request
Apr 24, 2026
…g new and old snapshot APIs (delta-io#5217) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description Updates various engine metrics suites to run with the new and old snapshot APIs. ## How was this patch tested? Test refactor. <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> ## Does this PR introduce _any_ user-facing changes? No. <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Updates various engine metrics suites to run with the new and old snapshot APIs.
How was this patch tested?
Test refactor.
Does this PR introduce any user-facing changes?
No.