Skip to content

Avoid overriding zipfile - #1

Merged
delijati merged 3 commits into
delijati:mainfrom
abravalheri:avoid-overriding-zipfile
Mar 15, 2022
Merged

delijati merged 3 commits into
delijati:mainfrom
abravalheri:avoid-overriding-zipfile

Conversation

@abravalheri

Copy link
Copy Markdown

Hi @delijati what do you think about the approach bellow?

This is more or less inline with my comment about reusing the functions of archive_util.

Summary of changes

  • I have split the existing unpack_zipfile function in a way that the internal loop can be used for zipfile objects
  • Then I replaced the extractall with this function
  • Finally instead of skipping the test completely on Windows, I changed the code to just skip the final mode check... This way we can see if everything still works fine on Windows.

Closes

Pull Request Checklist

@delijati

Copy link
Copy Markdown
Owner

oO Wow nice work :) The nice thing is that we reuse more code and have less copy paste +1 for me

@delijati
delijati merged commit d47c554 into delijati:main Mar 15, 2022
@abravalheri
abravalheri deleted the avoid-overriding-zipfile branch March 15, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants