Skip to content

fix: default keycloak realm envs - #455

Merged
chance-coleman merged 10 commits into
mainfrom
identity-env-vars
Jun 6, 2024
Merged

fix: default keycloak realm envs#455
chance-coleman merged 10 commits into
mainfrom
identity-env-vars

Conversation

@chance-coleman

@chance-coleman chance-coleman commented Jun 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Updating default values for keycloak realm settings, identity-config realm.json files now use default values in the realm.json so there is no need for default values to live in uds-core. So removed those default values and instead added a comment block of values that could be used to override the default values.

Related Issue

Relates to this uds-identity-config PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@chance-coleman
chance-coleman requested a review from a team June 4, 2024 17:35
@chance-coleman chance-coleman self-assigned this Jun 4, 2024
@chance-coleman chance-coleman mentioned this pull request Jun 4, 2024
Merged
5 tasks
@chance-coleman

chance-coleman commented Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

This wont pass CI until this PR is merged in uds-identity-config because keycloak is looking for the default env values still.

mjnagel
mjnagel reviewed Jun 5, 2024
View reviewed changes
Comment thread src/keycloak/chart/values.yaml Outdated
mjnagel
mjnagel previously approved these changes Jun 6, 2024
View reviewed changes
@chance-coleman
chance-coleman marked this pull request as ready for review June 6, 2024 15:49
@chance-coleman
chance-coleman merged commit 3a2b48f into main Jun 6, 2024
@chance-coleman
chance-coleman deleted the identity-env-vars branch June 6, 2024 15:55
@github-actions github-actions Bot mentioned this pull request Jun 6, 2024
Merged
mjnagel pushed a commit that referenced this pull request Jun 6, 2024
@github-actions
chore(main): release 0.22.1 (#432)
7cf9c4c 
🤖 I have created a release *beep* *boop*
---


##
[0.22.1](v0.22.0...v0.22.1)
(2024-06-06)


### Bug Fixes

* add saml configuration to k3d standard bundle
([#425](#425))
([15b41d7](15b41d7))
* de-duplicate renovate matches
([#435](#435))
([4f9dbbb](4f9dbbb))
* default keycloak realm envs
([#455](#455))
([3a2b48f](3a2b48f))
* exemption race conditions
([#407](#407))
([d1b3b56](d1b3b56))
* integrated docs
([#431](#431))
([72238fa](72238fa))
* keycloak schema for package cr
([#436](#436))
([e32ce9a](e32ce9a))
* networkpolicy for keycloak smtp egress
([4059954](4059954))
* nightly testing eks config architecture
([#452](#452))
([a0bbd1f](a0bbd1f))
* remove deprecated registry login and add env setup
([#443](#443))
([ca6b76f](ca6b76f))
* remove go mod
([#441](#441))
([0de9693](0de9693))
* remove no-tea and update uds version
([#446](#446))
([434844b](434844b))
* use updated k3s
([#426](#426))
([1da1c49](1da1c49))


### Miscellaneous

* add checks before killing pods when updating istio annotations
([#457](#457))
([a62f9a0](a62f9a0))
* add debug logs to save logs for easier searching
([#430](#430))
([319101b](319101b))
* add velero csi plugin
([#424](#424))
([c7e49e9](c7e49e9))
* **deps:** update githubactions
([#413](#413))
([ebd834e](ebd834e))
* **deps:** update istio to v1.22.1
([#405](#405))
([ad4b861](ad4b861))
* **deps:** update jest to v29.1.4
([#438](#438))
([c3ecc8b](c3ecc8b))
* **deps:** update keycloak to v0.4.4
([#460](#460))
([936f40b](936f40b))
* **deps:** update keycloak to v0.4.5
([#461](#461))
([3592012](3592012))
* **deps:** update keycloak to v24.0.5
([#453](#453))
([6b0c6fc](6b0c6fc))
* **deps:** update keycloak to v24.0.5
([#454](#454))
([89911f0](89911f0))
* **deps:** update pepr
([#419](#419))
([d8f0309](d8f0309))
* **deps:** update pepr to v0.4.5
([#447](#447))
([f1dba17](f1dba17))
* **deps:** update prometheus-stack
([#422](#422))
([a96193e](a96193e))
* **deps:** update uds-common to v0.4.4
([#442](#442))
([bf6debd](bf6debd))
* **deps:** update uds-k3d to v0.7.0
([#428](#428))
([23b59a2](23b59a2))
* **deps:** update velero
([#408](#408))
([ffbefda](ffbefda))
* **deps:** update velero
([#440](#440))
([4b1a3ea](4b1a3ea))
* **deps:** update velero to v6.6.0
([#456](#456))
([aff37c1](aff37c1))
* **deps:** update zarf to v0.34.0
([#434](#434))
([9badf9d](9badf9d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjnagel
mjnagel reviewed Jun 6, 2024
View reviewed changes
Comment thread src/keycloak/chart/values.yaml
# GOOGLE_IDP_CLIENT_SECRET: ""
# GOOGLE_IDP_ID: ""
# GOOGLE_IDP_SIGNING_CERT: ""
# GOOGLE_IDP_NALE_ID_FORMAT: ""

@mjnagel mjnagel Jun 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be NAME? Just realized when typing up release announcement...

@chance-coleman chance-coleman Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#462

rjferguson21 pushed a commit that referenced this pull request Jul 11, 2024
@chance-coleman
fix: default keycloak realm envs (#455)
dd47248 
## Description
Updating default values for keycloak realm settings, identity-config
realm.json files now use default values in the realm.json so there is no
need for default values to live in uds-core. So removed those default
values and instead added a comment block of values that could be used to
override the default values.

## Related Issue
[Relates to this uds-identity-config
PR](defenseunicorns/uds-identity-config#95)

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
rjferguson21 pushed a commit that referenced this pull request Jul 11, 2024
@github-actions
chore(main): release 0.22.1 (#432)
5ac4bd6 
🤖 I have created a release *beep* *boop*
---


##
[0.22.1](v0.22.0...v0.22.1)
(2024-06-06)


### Bug Fixes

* add saml configuration to k3d standard bundle
([#425](#425))
([15b41d7](15b41d7))
* de-duplicate renovate matches
([#435](#435))
([4f9dbbb](4f9dbbb))
* default keycloak realm envs
([#455](#455))
([3a2b48f](3a2b48f))
* exemption race conditions
([#407](#407))
([d1b3b56](d1b3b56))
* integrated docs
([#431](#431))
([72238fa](72238fa))
* keycloak schema for package cr
([#436](#436))
([e32ce9a](e32ce9a))
* networkpolicy for keycloak smtp egress
([4059954](4059954))
* nightly testing eks config architecture
([#452](#452))
([a0bbd1f](a0bbd1f))
* remove deprecated registry login and add env setup
([#443](#443))
([ca6b76f](ca6b76f))
* remove go mod
([#441](#441))
([0de9693](0de9693))
* remove no-tea and update uds version
([#446](#446))
([434844b](434844b))
* use updated k3s
([#426](#426))
([1da1c49](1da1c49))


### Miscellaneous

* add checks before killing pods when updating istio annotations
([#457](#457))
([a62f9a0](a62f9a0))
* add debug logs to save logs for easier searching
([#430](#430))
([319101b](319101b))
* add velero csi plugin
([#424](#424))
([c7e49e9](c7e49e9))
* **deps:** update githubactions
([#413](#413))
([ebd834e](ebd834e))
* **deps:** update istio to v1.22.1
([#405](#405))
([ad4b861](ad4b861))
* **deps:** update jest to v29.1.4
([#438](#438))
([c3ecc8b](c3ecc8b))
* **deps:** update keycloak to v0.4.4
([#460](#460))
([936f40b](936f40b))
* **deps:** update keycloak to v0.4.5
([#461](#461))
([3592012](3592012))
* **deps:** update keycloak to v24.0.5
([#453](#453))
([6b0c6fc](6b0c6fc))
* **deps:** update keycloak to v24.0.5
([#454](#454))
([89911f0](89911f0))
* **deps:** update pepr
([#419](#419))
([d8f0309](d8f0309))
* **deps:** update pepr to v0.4.5
([#447](#447))
([f1dba17](f1dba17))
* **deps:** update prometheus-stack
([#422](#422))
([a96193e](a96193e))
* **deps:** update uds-common to v0.4.4
([#442](#442))
([bf6debd](bf6debd))
* **deps:** update uds-k3d to v0.7.0
([#428](#428))
([23b59a2](23b59a2))
* **deps:** update velero
([#408](#408))
([ffbefda](ffbefda))
* **deps:** update velero
([#440](#440))
([4b1a3ea](4b1a3ea))
* **deps:** update velero to v6.6.0
([#456](#456))
([aff37c1](aff37c1))
* **deps:** update zarf to v0.34.0
([#434](#434))
([9badf9d](9badf9d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@chance-coleman @mjnagel
fix: default keycloak realm envs (defenseunicorns#455)
bb222f9 
## Description
Updating default values for keycloak realm settings, identity-config
realm.json files now use default values in the realm.json so there is no
need for default values to live in uds-core. So removed those default
values and instead added a comment block of values that could be used to
override the default values.

## Related Issue
[Relates to this uds-identity-config
PR](defenseunicorns/uds-identity-config#95)

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@github-actions @mjnagel
chore(main): release 0.22.1 (defenseunicorns#432)
5821e1d 
🤖 I have created a release *beep* *boop*
---


##
[0.22.1](defenseunicorns/uds-core@v0.22.0...v0.22.1)
(2024-06-06)


### Bug Fixes

* add saml configuration to k3d standard bundle
([defenseunicorns#425](defenseunicorns#425))
([15b41d7](defenseunicorns@15b41d7))
* de-duplicate renovate matches
([defenseunicorns#435](defenseunicorns#435))
([4f9dbbb](defenseunicorns@4f9dbbb))
* default keycloak realm envs
([defenseunicorns#455](defenseunicorns#455))
([3a2b48f](defenseunicorns@3a2b48f))
* exemption race conditions
([defenseunicorns#407](defenseunicorns#407))
([d1b3b56](defenseunicorns@d1b3b56))
* integrated docs
([defenseunicorns#431](defenseunicorns#431))
([72238fa](defenseunicorns@72238fa))
* keycloak schema for package cr
([defenseunicorns#436](defenseunicorns#436))
([e32ce9a](defenseunicorns@e32ce9a))
* networkpolicy for keycloak smtp egress
([4059954](defenseunicorns@4059954))
* nightly testing eks config architecture
([defenseunicorns#452](defenseunicorns#452))
([a0bbd1f](defenseunicorns@a0bbd1f))
* remove deprecated registry login and add env setup
([defenseunicorns#443](defenseunicorns#443))
([ca6b76f](defenseunicorns@ca6b76f))
* remove go mod
([defenseunicorns#441](defenseunicorns#441))
([0de9693](defenseunicorns@0de9693))
* remove no-tea and update uds version
([defenseunicorns#446](defenseunicorns#446))
([434844b](defenseunicorns@434844b))
* use updated k3s
([defenseunicorns#426](defenseunicorns#426))
([1da1c49](defenseunicorns@1da1c49))


### Miscellaneous

* add checks before killing pods when updating istio annotations
([defenseunicorns#457](defenseunicorns#457))
([a62f9a0](defenseunicorns@a62f9a0))
* add debug logs to save logs for easier searching
([defenseunicorns#430](defenseunicorns#430))
([319101b](defenseunicorns@319101b))
* add velero csi plugin
([defenseunicorns#424](defenseunicorns#424))
([c7e49e9](defenseunicorns@c7e49e9))
* **deps:** update githubactions
([defenseunicorns#413](defenseunicorns#413))
([ebd834e](defenseunicorns@ebd834e))
* **deps:** update istio to v1.22.1
([defenseunicorns#405](defenseunicorns#405))
([ad4b861](defenseunicorns@ad4b861))
* **deps:** update jest to v29.1.4
([defenseunicorns#438](defenseunicorns#438))
([c3ecc8b](defenseunicorns@c3ecc8b))
* **deps:** update keycloak to v0.4.4
([defenseunicorns#460](defenseunicorns#460))
([936f40b](defenseunicorns@936f40b))
* **deps:** update keycloak to v0.4.5
([defenseunicorns#461](defenseunicorns#461))
([3592012](defenseunicorns@3592012))
* **deps:** update keycloak to v24.0.5
([defenseunicorns#453](defenseunicorns#453))
([6b0c6fc](defenseunicorns@6b0c6fc))
* **deps:** update keycloak to v24.0.5
([defenseunicorns#454](defenseunicorns#454))
([89911f0](defenseunicorns@89911f0))
* **deps:** update pepr
([defenseunicorns#419](defenseunicorns#419))
([d8f0309](defenseunicorns@d8f0309))
* **deps:** update pepr to v0.4.5
([defenseunicorns#447](defenseunicorns#447))
([f1dba17](defenseunicorns@f1dba17))
* **deps:** update prometheus-stack
([defenseunicorns#422](defenseunicorns#422))
([a96193e](defenseunicorns@a96193e))
* **deps:** update uds-common to v0.4.4
([defenseunicorns#442](defenseunicorns#442))
([bf6debd](defenseunicorns@bf6debd))
* **deps:** update uds-k3d to v0.7.0
([defenseunicorns#428](defenseunicorns#428))
([23b59a2](defenseunicorns@23b59a2))
* **deps:** update velero
([defenseunicorns#408](defenseunicorns#408))
([ffbefda](defenseunicorns@ffbefda))
* **deps:** update velero
([defenseunicorns#440](defenseunicorns#440))
([4b1a3ea](defenseunicorns@4b1a3ea))
* **deps:** update velero to v6.6.0
([defenseunicorns#456](defenseunicorns#456))
([aff37c1](defenseunicorns@aff37c1))
* **deps:** update zarf to v0.34.0
([defenseunicorns#434](defenseunicorns#434))
([9badf9d](defenseunicorns@9badf9d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjnagel mjnagel mjnagel approved these changes

Assignees

@chance-coleman chance-coleman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chance-coleman @mjnagel