Repository navigation
[AffineIR] Plan expert transfers from the live runtime placement #8800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9637a10
[AutoEP] Plan expert transfers from the live runtime placement
jinyouzhi c02604d
Document the AutoEP expert transfer-planning API
jinyouzhi 939e7f5
Merge remote-tracking branch 'origin/master' into autoep-live-affine-map
jinyouzhi 1b8298f
Merge branch 'master' into autoep-live-affine-map
jinyouzhi 4660e0d
[CKPT] Describe AutoEP expert storage across EDP replicas and ZeRO-3 …
jinyouzhi 46385d4
Merge remote-tracking branch 'myfork/autoep-live-affine-map' into aut…
jinyouzhi 2613999
Merge branch 'master' into autoep-live-affine-map
jinyouzhi 6eef8fc
Build AutoEP expert storage maps without a collective
jinyouzhi da9ea87
Keep the expert data parallel table when one EDP subgroup is destroyed
jinyouzhi e1dd84b
Correct why the expert storage map uses a flat logical shape
jinyouzhi fbb8c6a
Move AutoEP expert storage maps to a separate change
jinyouzhi 5cf957b
docs: do not mention expert rebalancing for AutoEP transfer planning
jinyouzhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For downstream code that consumes these new public planning methods, the dedicated AutoEP documentation and affine IR specification remain unchanged, so users are not given a discoverable contract for constructing
target_placement, translating the separate source/target EP-local rank namespaces, or normalizing ZeRO/EDP storage before applying segment offsets. Add this API and its placement/normalization requirements todocs/code-docs/source/autoep.rstor the affine specification rather than relying only on implementation docstrings.AGENTS.md reference: AGENTS.md:L26-L26
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in c02604d: a "Planning expert placement transfers" section in
docs/code-docs/source/autoep.rstcovering how to buildtarget_placementwithmake_autoep_placement_descriptor, the source/target EP-local rank namespaces (anddist.get_global_rank(layer.ep_group, rank)), element offsets into the unpartitioned packed[local_experts, ...]tensor (gather under ZeRO-3; EDP replicas hold the same tensor), replica selection,PlanBudgetlimits, and the uniform live-placement requirement.affine_ir_spec.md§8.4 now points to the runtime API.