Skip to content

chore: deprecate datadog tracer + update docs#11643

Merged
sjrl merged 5 commits into
mainfrom
deprecate-datadog-tracer
Jun 16, 2026
Merged

chore: deprecate datadog tracer + update docs#11643
sjrl merged 5 commits into
mainfrom
deprecate-datadog-tracer

Conversation

@sjrl

@sjrl sjrl commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

deprecate usage of DatadogTracer in Haystack core and point users to new integration

How did you test it?

added new unit test

Notes for the reviewer

Waiting for release of new integration datadog-haystack before merging

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jun 16, 2026 9:48am

Request Review

@sjrl sjrl self-assigned this Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  haystack/tracing
  datadog.py
Project Total  

This report was generated by python-coverage-comment-action

@sjrl sjrl marked this pull request as ready for review June 16, 2026 08:25
@sjrl sjrl requested a review from a team as a code owner June 16, 2026 08:25
@sjrl sjrl requested review from anakin87 and removed request for a team June 16, 2026 08:25
@claude

claude Bot commented Jun 16, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

anakin87
anakin87 requested changes Jun 16, 2026
View reviewed changes
Comment thread docs-website/docs/development/tracing.mdx
tracing.enable_tracing(DatadogTracer(tracer))
```
:::info
Check out the [integration page](https://haystack.deepset.ai/integrations/datadog) for more details and example usage.

@anakin87 anakin87 Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that in general the integration page is just a showcase but our docs should be the source of truth, so I'd not point users to the integration page.

I'd update this section and/or create a new page for the component.

@sjrl sjrl Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair but should we do that in a follow up PR? This is following the same format as is done for our other tracers in this page where we just link to the integration page and only for mlflow do we show a small amount of code set up.

@anakin87 anakin87 Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please take care of this

@sjrl sjrl Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened issue for it here #11655

@sjrl sjrl Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you're right we already document our connector components sorry for missing that. Adding the datadog connector docs to this PR

@sjrl sjrl Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anakin87 could I get one more review on the new connectors page I added?

Comment thread releasenotes/notes/deprecate-datadog-tracer-8b3e6c1d2a9f4e05.yaml
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jun 16, 2026
@sjrl sjrl requested a review from anakin87 June 16, 2026 09:49
anakin87
anakin87 approved these changes Jun 16, 2026
View reviewed changes

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sjrl sjrl enabled auto-merge (squash) June 16, 2026 10:04
@sjrl sjrl merged commit 3ae35a5 into main Jun 16, 2026
29 checks passed
@sjrl sjrl deleted the deprecate-datadog-tracer branch June 16, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees

@sjrl sjrl

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjrl @anakin87