Skip to content

fix: correct typo in Pipeline.load() docstring#11632

Merged
sjrl merged 3 commits into
deepset-ai:mainfrom
Kunal-Somani:fix/pipeline-load-docstring-typo
Jun 15, 2026
Merged

fix: correct typo in Pipeline.load() docstring#11632
sjrl merged 3 commits into
deepset-ai:mainfrom
Kunal-Somani:fix/pipeline-load-docstring-typo

Conversation

@Kunal-Somani

Copy link
Copy Markdown
Contributor

Related Issues

  • No related issue (documentation typo fix)

Proposed Changes:

Fixed a missing word typo in the Pipeline.load() method docstring in haystack/core/pipeline/base.py.

The docstring previously read:

"Creates a Pipeline object a string representation."

It now correctly reads:

"Creates a Pipeline object from a string representation."

How did you test it?

  • Verified the fix visually in haystack/core/pipeline/base.py
  • Ran the full pipeline test suite locally: PYTHONPATH="" hatch run test:unit test/core/pipeline/ — 359 passed, 0 failures
  • Ran type checks: hatch run test:types — no issues found in 365 source files
  • Ran formatter: hatch run fmt — all checks passed, no changes needed
  • All pre-commit hooks passed at commit time

Notes for the reviewer

Single-word docstring fix, no functional or behavioral change whatsoever. Safe to merge without additional review of logic.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@Kunal-Somani Kunal-Somani requested a review from a team as a code owner June 15, 2026 06:21
@Kunal-Somani Kunal-Somani requested review from sjrl and removed request for a team June 15, 2026 06:21
@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

@Kunal-Somani is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Jun 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! We don't need a release note for this change so feel free to delete this file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @sjrl! I've signed the CLA and removed the release note file.

@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 15, 2026
@sjrl

sjrl commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Hey @Kunal-Somani thanks for the contribution! Please sign the CLA agreement #11632 (comment) otherwise we can't accept the contribution.

@sjrl sjrl self-assigned this Jun 15, 2026
@sjrl sjrl enabled auto-merge (squash) June 15, 2026 07:04
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jun 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/websearch
  serper_dev.py
  haystack/utils
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

@sjrl sjrl disabled auto-merge June 15, 2026 07:17

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjrl sjrl merged commit ba27d46 into deepset-ai:main Jun 15, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants