Conversation
GET /dating-exam/optional 엔드포인트와 이로 인해 사용되지 않게 된 DatingExamFinder.findOptionalExamInfo (인터페이스 + 구현) 제거. SubjectType.OPTIONAL enum은 제출/소울메이트 흐름에서 계속 사용되므로 유지.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Walkthrough
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test results814 tests 814 ✅ 15s ⏱️ Results for commit 3ca9b95. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
GET /dating-exam/optional선택 과목 정보 조회 API를 삭제합니다.변경 사항
DatingExamApi.getOptionalExamInfo제거DatingExamFinder.findOptionalExamInfo(인터페이스 +DatingExamQueryService구현) 제거SubjectType.OPTIONALenum은 제출/소울메이트 흐름에서 계속 사용되므로 유지검증
./gradlew compileJava통과getOptionalExamInfo/findOptionalExamInfo잔존 참조 없음 (남은 1건은 레포지토리 테스트 메서드명으로 무관)Closes #451
Summary by CodeRabbit