fix(qe): use ndmin=2 in np.loadtxt to handle single-line .evp files#900
Merged
wanghan-iapcm merged 3 commits intodevelfrom Sep 23, 2025
Merged
fix(qe): use ndmin=2 in np.loadtxt to handle single-line .evp files#900wanghan-iapcm merged 3 commits intodevelfrom
wanghan-iapcm merged 3 commits intodevelfrom
Conversation
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [BUG] Converting from Quantum Espresso cp.x traj gives error when there is only one line in the energy output file
fix(qe): use ndmin=2 in np.loadtxt to handle single-line .evp files
Sep 20, 2025
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
CodSpeed WallTime Performance ReportMerging #900 will not alter performanceComparing
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #900 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 83 83
Lines 7886 7886
=======================================
Hits 6787 6787
Misses 1099 1099 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wanghan-iapcm
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Quantum Espresso cp.x trajectory files contain only a single timestep, the
.evpenergy file has just one data line. This causednp.loadtxt()to return a 1D array instead of the expected 2D array, leading to an IndexError when the code attempted 2D indexing operations.The fix uses numpy's
ndmin=2parameter to ensure the loaded data is always at least 2-dimensional, maintaining consistency between single-line and multi-line energy files without requiring additional reshaping logic.Changes:
ndmin=2parameter tonp.loadtxt()call inload_energy()functionTesting:
.evpfile handlingFixes #899.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.