feat: add support for multiple LAMMPS atom styles with automatic detection#867
feat: add support for multiple LAMMPS atom styles with automatic detection#867wanghan-iapcm merged 10 commits intodevelfrom
Conversation
|
@njzjz 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
…t automatic detection Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #867 +/- ##
==========================================
- Coverage 85.48% 85.47% -0.02%
==========================================
Files 82 82
Lines 7607 7675 +68
==========================================
+ Hits 6503 6560 +57
- Misses 1104 1115 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed WallTime Performance ReportMerging #867 will not alter performanceComparing Summary
|
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…tomatic detection in tests Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
… to reduce code duplication Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Added comprehensive type hints to all new methods including the core parsing functions in |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
LGTM (the CI status is not related) - @wanghan-iapcm, please double-check the PR.
|
@copilot Use conventional commit format for the PR title. |
I cannot directly change the PR title as I don't have permissions to update PR metadata. However, the conventional commit format for this PR title should be:
You can update the PR title manually to follow this conventional commit format. |
This PR adds comprehensive support for different LAMMPS atom styles beyond the previously supported "atomic" style. The implementation now supports 8 common LAMMPS atom styles with automatic detection and charge extraction while maintaining full backward compatibility.
Supported Atom Styles
Key Features
Atoms # full) with intelligent fallback based on column analysisatom_style="auto"is now the default, eliminating the need for manual specification in most casesUsage
Implementation Details
The solution adds intelligent atom style detection that:
All parsing functions (
get_atype,get_posi,get_charges) were updated to handle different column arrangements with full type hints. Comprehensive tests cover both comment-based and heuristic detection scenarios.Fixes #853.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.