limit the filename length dumped by MultiSystems#554
Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom Oct 15, 2023
Merged
limit the filename length dumped by MultiSystems#554wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
Conversation
Fix deepmodeling#553. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #554 +/- ##
==========================================
+ Coverage 82.86% 82.90% +0.04%
==========================================
Files 73 73
Lines 6523 6541 +18
==========================================
+ Hits 5405 5423 +18
Misses 1118 1118
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Oct 15, 2023
njzjz
added a commit
to njzjz/dpdata
that referenced
this pull request
Feb 4, 2026
deepmodeling#554 dumps file names in short name. However, `dpgen simplify` replies on the filename to find a system in MultiSystems. This commit makes it possible to find a system by its short name.
wanghan-iapcm
pushed a commit
that referenced
this pull request
Feb 5, 2026
#554 dumps file names in short name. However, `dpgen simplify` replies on the filename to find a system in MultiSystems. This commit makes it possible to find a system by its short name. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Systems in collections can now be accessed by their short name as well as by formula-based keys. * **Tests** * Added test coverage verifying index-based access using a system's short name. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <njzjz@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #553.