Skip to content

run benchmarks#5

Merged
tachella merged 6 commits intomainfrom
run-benchmark
Jan 28, 2026
Merged

run benchmarks#5
tachella merged 6 commits intomainfrom
run-benchmark

Conversation

@tachella
Copy link
Contributor

@tachella tachella commented Jan 16, 2026

This PR adds the run_benchmark function to this repo such that users can quickly evaluate their model on a given benchmark as

from deepinv_bench import run_benchmark
my_solver = lambda y, physics: ...  # your solver here
results = run_benchmark(my_solver, "benchmark_name")

@tomMoral is there an easy way to do this with benchopt? see todo in the PR :)

Copy link
Contributor Author

@tachella tachella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for the proposed solution!

I'm getting an error when running locally, I was wondering if you get the same?

from deepinv.models import Reconstructor


class DummyModel(Reconstructor):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make it possible to run the benchmark with the CLI. We need the model to be valid.
Also this model is useful for testing the objective maybe worth putting in deepinv? (Like sklearn.dummy which gives you random perf)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make it possible to run the benchmark with the CLI. We need the model to be valid.
Also this model is useful for testing the objective maybe worth putting in deepinv? (Like sklearn.dummy which gives you random perf)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - you can do this model as dinv.models.ArtifactRemoval (see here) and a dummy (identity denoiser). I think we could later on add the option to pass None to the denoiser

@tachella tachella merged commit 892a08d into main Jan 28, 2026
2 checks passed
@tomMoral tomMoral deleted the run-benchmark branch January 28, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants