Conversation
tachella
left a comment
There was a problem hiding this comment.
many thanks for the proposed solution!
I'm getting an error when running locally, I was wondering if you get the same?
| from deepinv.models import Reconstructor | ||
|
|
||
|
|
||
| class DummyModel(Reconstructor): |
There was a problem hiding this comment.
why do we need this?
There was a problem hiding this comment.
This is to make it possible to run the benchmark with the CLI. We need the model to be valid.
Also this model is useful for testing the objective maybe worth putting in deepinv? (Like sklearn.dummy which gives you random perf)
There was a problem hiding this comment.
This is to make it possible to run the benchmark with the CLI. We need the model to be valid.
Also this model is useful for testing the objective maybe worth putting in deepinv? (Like sklearn.dummy which gives you random perf)
There was a problem hiding this comment.
I see - you can do this model as dinv.models.ArtifactRemoval (see here) and a dummy (identity denoiser). I think we could later on add the option to pass None to the denoiser
This PR adds the
run_benchmarkfunction to this repo such that users can quickly evaluate their model on a given benchmark as@tomMoral is there an easy way to do this with benchopt? see todo in the PR :)