Ability to suppress timestamps when useColors is false - maintains backwards compatibility#488
Closed
rynmsh wants to merge 2 commits intodebug-js:masterfrom
Closed
Ability to suppress timestamps when useColors is false - maintains backwards compatibility#488rynmsh wants to merge 2 commits intodebug-js:masterfrom
rynmsh wants to merge 2 commits intodebug-js:masterfrom
Conversation
Member
|
Closing in favor of #582. Please comment there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To provide the option to disable printing of timestamps when userColours is false. Will maintain the default behaviour if its not set for backwards compatibility.
Reasons for this change have been mentioned in some comments already - the need to disable the double logging of timestamps in systems that already print timestamps.
https://travis-ci.org/rynmsh/debug