Skip to content

Parse native MiniMax reasoning and tool calls - #970

Draft
sjordan0228 wants to merge 1 commit into
ddalcu:mainfrom
sjordan0228:feat/minimax-native-protocol
Draft

sjordan0228 wants to merge 1 commit into
ddalcu:mainfrom
sjordan0228:feat/minimax-native-protocol

Conversation

@sjordan0228

Copy link
Copy Markdown

What changed / why
MiniMax's native reasoning markers and namespaced tool XML fall through the shared parsers. Preserve input token spelling, decode reasoning canonically, parse nested tool strings/objects/lists, buffer partial namespace prefixes, and refuse incomplete native calls.
Top-level scalar types follow the tool schema; nested scalar coercion and empty-container typing remain unsupported. This parser change is independent of MiniMax model registration and its experimental runtime.
How I verified it
Apple M4, macOS 26.5.2, isolated three-file patch with the existing plugin pin: CPU-configured zig build test passed 4,773 tests / 653 skipped; ReleaseFast build passed 8/8 and --version ran successfully. Focused MiniMax checks passed 31/31 overall.
Removing native dispatch made both unchanged tool guards fail; dispatch was restored before the full passing run. Native HTTP/repeated-client checks remain pending.

  • Searched open and closed issues, open PRs and recent commits; linked the existing thread if there is one
  • Built and ran this tree on a real Apple Silicon Mac in this session
  • No comments that restate code, carry history, or cite audit/review items
  • No source-scan tests; every test checks behaviour
  • One fix or feature; description under ~15 lines

@sjordan0228

Copy link
Copy Markdown
Author

The MiniMax parser and reasoning changes are now ported locally onto the merged rewrite. ReleaseFast builds successfully. The focused reasoning suite passed 196 tests with one skipped, including native and decoded marker handling. Full-suite validation is still pending: both attempts exceeded the available memory on my 16 GB laptop. Keeping this draft until that validation is complete.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant