Repository navigation
Parse native MiniMax reasoning and tool calls - #970
Draft
sjordan0228 wants to merge 1 commit into
Draft
sjordan0228 wants to merge 1 commit into
sjordan0228 wants to merge 1 commit into
Conversation
5 tasks done
Author
|
The MiniMax parser and reasoning changes are now ported locally onto the merged rewrite. ReleaseFast builds successfully. The focused reasoning suite passed 196 tests with one skipped, including native and decoded marker handling. Full-suite validation is still pending: both attempts exceeded the available memory on my 16 GB laptop. Keeping this draft until that validation is complete. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / why
MiniMax's native reasoning markers and namespaced tool XML fall through the shared parsers. Preserve input token spelling, decode reasoning canonically, parse nested tool strings/objects/lists, buffer partial namespace prefixes, and refuse incomplete native calls.
Top-level scalar types follow the tool schema; nested scalar coercion and empty-container typing remain unsupported. This parser change is independent of MiniMax model registration and its experimental runtime.
How I verified it
Apple M4, macOS 26.5.2, isolated three-file patch with the existing plugin pin: CPU-configured zig build test passed 4,773 tests / 653 skipped; ReleaseFast build passed 8/8 and --version ran successfully. Focused MiniMax checks passed 31/31 overall.
Removing native dispatch made both unchanged tool guards fail; dispatch was restored before the full passing run. Native HTTP/repeated-client checks remain pending.