Repository navigation
test(scripts): use waitFor; skip false-positives - #510
Merged
Merged
Conversation
AviVahl
commented
Nov 16, 2020
AviVahl
commented
Contributor
- our app is dynamically loading, so we want to wait for the body to load (or we get flakiness in slower CI).
- two tests injecting stuff to Application.run() were already broken. The if statements inside the waitFor caused noop to happen, as waitFor expects a throw/rejection to retry. noop means all is good in tests, so false positive.
- our app is dynamically loading, so we want to wait for the body to load (or we get flakiness in slower CI). - two tests injecting stuff to Application.run() were already broken. The if statements inside the waitFor caused noop to happen, as waitFor expects a throw/rejection to retry. noop means all is good in tests, so false positive.
AviVahl
force-pushed
the
avi/test-stability-fixes
branch
from
November 16, 2020 00:13
bbbba2a to
9ba19d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.