Skip to content

Generic entity formatting#31

Merged
nblumhardt merged 3 commits into
datalust:devfrom
nblumhardt:entity-output-formatter
Mar 2, 2018
Merged

Generic entity formatting#31
nblumhardt merged 3 commits into
datalust:devfrom
nblumhardt:entity-output-formatter

Conversation

@nblumhardt

Copy link
Copy Markdown
Member

Had a shot at generic output formatting for entities, i.e. what we'll get from apikey list type commands:

screenshot from 2018-03-01 20-52-05

The results are okay - there are three modes, text (Id/Title pair), JSON (colorized via Serilog...) and plain JSON. It's a hideously inefficient way to output JSON, but not too bad to read. An --indented option might be desirable someday.

Hacked inSorted out the seqcli help <command> <subcommand> functionality en route.

@nblumhardt

Copy link
Copy Markdown
Member Author

I dropped two test cases for the:

cmd
cmd subcommand

situation where both the top-level command and subcommand are valid; I don't think, with the current CLI, it's likely we'll use the top-level commands for things like apikey, signal, etc. - though it shouldn't be too hard to bring that possibility back if we decide we need it.

@nblumhardt

Copy link
Copy Markdown
Member Author

r? @KodrAus @andymac4182

@KodrAus KodrAus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@nblumhardt nblumhardt merged commit 1bdce37 into datalust:dev Mar 2, 2018
@nblumhardt

Copy link
Copy Markdown
Member Author

Thanks @KodrAus 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants