Plain text ingestion WIP: read frames of input with trailing lines#18
Merged
Conversation
nblumhardt
commented
Feb 21, 2018
|
|
||
| var text = Content(next.Location); | ||
| while (text.HasValue) | ||
| while (text.HasValue || !text.Remainder.IsAtEnd) |
Member
Author
There was a problem hiding this comment.
This was necessary to deal with the change from While() to WithoutAny() a few lines earlier. The former created zero-length matches, while the latter doesn't.
We can revert to the earlier approach when something like Span.MatchedBy(Character.Except('"').Many()) can be expressed in Superpower.
KodrAus
approved these changes
Feb 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR establishes a way of reading logs in real-time from STDIN; the eventual usage will be:
The major requirement dealt with here is the need to ingest multi-line messages; we do this by:
TextParser<TextSpan>This ensures that output like:
can be read into a single frame, without waiting for another message to confirm that no further stack trace lines are coming.
Not the most efficient implementation, but does successfully avoid synchronization.
One snag, the
Console.In.ReadLineAsync()method blocks without returning aTask, at least on .NET Core/Windows, so an additionalTask.Run()was required.