fix: Support 'KEY' in fetch() for backward compatibility #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In DataJoint 0.14, fetch('KEY') was a special syntax that returned
primary key columns as list of dicts. This was broken in 2.0.
Changes:
- fetch('KEY') returns list of primary key dicts
- fetch('KEY', 'col') returns (keys_list, col_array)
- fetch('KEY', as_dict=True) expands KEY to primary key columns
Fixes #1381
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fetch('KEY')which was a special syntax in DataJoint 0.14fetch('KEY')returns list of primary key dictsfetch('KEY', 'col')returns(keys_list, col_array)fetch('KEY', as_dict=True)expands KEY to primary key columnsFixes #1381
Test plan
test_fetch_KEY- verifiesfetch('KEY')returns list of dictstest_fetch1_KEY- verifiesfetch1('KEY')returns single dicttest_fetch_KEY_with_other_attrs- verifies mixed attrs work🤖 Generated with Claude Code