fix: Disable semantic_check for job table subtraction in refresh() #1383
+54
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-` operator calls `.restrict(Not(x))` without passing `semantic_check=False`. When `keep_completed=True`, the subtraction `- self._target` fails because: - Job table's PK has lineage `~~table.attr` (defined in job table) - Target table's PK has lineage `#parent.attr` (from foreign key) Replace `-` operator with explicit `.restrict(Not(...), semantic_check=False)`. Also move `Not` import to top-level (was local import). Fixes #1379 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Regression tests for #1379 - verify that populate(reserve_jobs=True) works correctly when keep_completed=True and add_job_metadata=True. Tests: - test_populate_reserve_jobs_with_keep_completed: Basic populate works - test_populate_reserve_jobs_keep_completed_repend: Deleted results are re-pended Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ttngu207
approved these changes
Feb 5, 2026
The experiment table is already populated by the fixture, so populate() had nothing to do. Delete the data first to ensure there's work to be done. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The repend test was failing because experiment table has compound PK but jobs only track subject_id (due to non-FK attribute warning). Replace with simpler test that directly tests jobs.refresh() behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
populate(reserve_jobs=True)failing whendj.config.jobs.keep_completed=True-operator doesn't passsemantic_check=False, causing semantic matching to failProblem
When
keep_completed=True, therefresh()method tries to find completed jobs that need to be re-pended:The
.restrict()correctly disables semantic check, but the-operator calls.restrict(Not(x))withoutsemantic_check=False. This causes a lineage mismatch error:The lineages differ because:
~~table.attr)#parent.attr)Solution
Replace the
-operator with explicit.restrict(Not(...), semantic_check=False):Fixes #1379
🤖 Generated with Claude Code