Fix Diagram.make_dot for pydot 3.* compatibility#1177
Fix Diagram.make_dot for pydot 3.* compatibility#1177dimitri-yatsenko merged 8 commits intomasterfrom
Conversation
Before running `to_pydot`, we encapsulate node names and attr_map in double quotes to avoid syntax errors when the node names contain special characters. Implements the workarounds described in #1176 (comment) and pydot/pydot#258 (comment)
|
@ethho This looks good from first glance. I'll try to check this sometime over the weekend/monday to confirm that this works and get back to you on this. Thank you for addressing this so quickly. |
|
Sure thing, thank you @tabedzki for doing the heavy lifting of investigating! |
|
@ethho re-running the same example that I used for #1176, this works without requiring the latest version of I'd say all that is left is to update the change log and list out all the issues here that this PR closes so clear up some of the backlog. I'll close my PR. Package versions: DOT representation of the graph truncated: |
Encapsulates node names and edge attribute
attr_mapin double quotes before callingto_pydotin methodDiagram.make_dot. Partially duplicates changes made in #1176.Closes #1175 and closes #1169 and closes #1100 and closes #1065. May close related issue #1072.