Closed
Conversation
Closed
Closed
…into hidden-attr-alt
dimitri-yatsenko
approved these changes
Sep 12, 2024
Member
dimitri-yatsenko
left a comment
dimitri-yatsenko
left a comment
There was a problem hiding this comment.
@ethho Let's merge and this will be used in support of other features.
ethho
reviewed
Sep 12, 2024
| if self._attributes is None: | ||
| self._init_from_database() # lazy loading from database | ||
| return self._attributes | ||
| return {k: v for k, v in self._attributes.items() if not v.is_hidden} |
Contributor
There was a problem hiding this comment.
Note: this changes from direct access to the _attributes dictionary to a copy. This means that the following will raise AssertionError as of this PR, but not on master:
orig_value = my_table.heading.attributes['my_attr']
my_table.heading.attributes['my_attr'] = "foo"
assert my_table.heading.attributes['my_attr'] == "foo"
assert my_table.heading.attributes['my_attr'] != orig_value
ethho
added a commit
that referenced
this pull request
Sep 12, 2024
Contributor
|
Moving development to #1180, which merges |
dimitri-yatsenko
added a commit
that referenced
this pull request
Sep 12, 2024
hidden attributes continued (#1091)
ethho
added a commit
that referenced
this pull request
Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.