Skip to content

feat(ui): replace antd tooltips and popovers with FloatingOverlay #19870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annadoesdesign merged 16 commits into from
Sep 29, 2026
Merged

feat(ui): replace antd tooltips and popovers with FloatingOverlay #19870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9fd6fa8
updates on dark mode colors and beta tag
annadoesdesign Sep 18, 2026
10f1f9d
fix(darkmode): add dedicated bgOverlay token for floating surfaces
annadoesdesign Sep 18, 2026
1f85cad
fix(darkmode): track bg for overlay surfaces and strengthen dark shadows
annadoesdesign Sep 18, 2026
3da88b6
refactor(ui): replace antd tooltips with a unified Alchemy hover card
annadoesdesign Sep 18, 2026
c91f5c7
Merge branch 'master' into ae--fix-tooltips
annadoesdesign Sep 28, 2026
104fb47
fix(ui): address FloatingOverlay review findings
annadoesdesign Sep 28, 2026
29357af
fix(ui): repair merge leftovers from master
annadoesdesign Sep 28, 2026
2a3c834
refactor(ui): move entity hover card work to a follow-up PR
annadoesdesign Sep 28, 2026
ef12e1e
fix(ui): forward ref from Icon so tooltips can anchor to it
annadoesdesign Sep 28, 2026
4df1b67
feat(ui): unify entity hover cards into EntityHoverCard (#20047)
annadoesdesign Sep 29, 2026
fe200bc
Merge origin/master into ae--fix-tooltips
annadoesdesign Sep 29, 2026
465ecf0
fix(ui): address review feedback on tooltip and hover card overlays
annadoesdesign Sep 29, 2026
7b283ea
fix overlay
annadoesdesign Sep 29, 2026
6c7ea5c
floatingOverlay was wrapping SVG calendar day cells in an HTML <span>.
annadoesdesign Sep 29, 2026
93f6e34
fix lint
annadoesdesign Sep 29, 2026
b9f5de4
fix(ui): let calendar day popovers pass hovers to covered days
annadoesdesign Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion datahub-web-react/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ export default {
},
stories: [
'../src/alchemy-components/.docs/*.mdx',
'../src/alchemy-components/components/**/*.stories.@(js|jsx|mjs|ts|tsx)'
'../src/alchemy-components/components/**/*.stories.@(js|jsx|mjs|ts|tsx)',
// App-level compositions (e.g. the entity hover card) that build on alchemy components but
// depend on GraphQL types, so they can't live under `alchemy-components`.
'../src/app/**/*.stories.@(js|jsx|mjs|ts|tsx)',
],
addons: [
'@storybook/addon-onboarding',
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"@dnd-kit/modifiers": "^9.0.0",
"@dnd-kit/sortable": "^10.0.0",
"@dnd-kit/utilities": "^3.2.2",
"@floating-ui/react-dom": "^2.1.9",
"@fontsource/mulish": "^5.0.16",
"@geometricpanda/storybook-addon-badges": "^2.0.2",
"@graphql-codegen/fragment-matcher": "^5.0.0",
Expand Down
4 changes: 4 additions & 0 deletions datahub-web-react/src/alchemy-components/components/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,7 @@ export const Button = ({
</ButtonBase>
);
};

// `FloatingOverlay` keys off this to wrap a disabled button. A disabled native button
// never fires the hover listeners, so the tooltip has to listen on a parent instead.
Button.displayName = 'Button';
9 changes: 8 additions & 1 deletion datahub-web-react/src/alchemy-components/components/CalendarChart/private/components/Day.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,14 @@ export function Day<ValueType>({ day, weekOffset, dayIndex }: DayProps<ValueType

if (showPopover) {
return (
<Popover placement="topLeft" content={popoverRenderer?.(day)}>
<Popover
placement="topLeft"
content={popoverRenderer?.(day)}
// Opens above this 16px square, which is exactly where the previous day sits.
// The box must not catch that hover. Controls inside the content opt back in.
overlayStyle={{ pointerEvents: 'none' }}
overlayInnerStyle={{ pointerEvents: 'none' }}

@cursor cursor Bot Sep 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View details button stays unreachable

Medium Severity

pointerEvents: 'none' on the day overlay lets hover reach the previous cell, but FloatingOverlay still closes 100ms after trigger mouseleave. The View details Button sets pointerEvents: 'auto', yet the path to it crosses the 8px offset and 12px padding sitting over that previous day, so the popover closes or switches before a click can land.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b9f5de4. Configure here.

>
{renderBar()}
</Popover>
);
Expand Down
Loading
Loading