Skip to content

[Iceberg] Add Iceberg crate dependencies - #597

Open
gabotechs wants to merge 1 commit into
gabrielmusat/add-taxi-iceberg-datasetfrom
gabrielmusat/add-empty-iceberg-crate
Open

[Iceberg] Add Iceberg crate dependencies#597
gabotechs wants to merge 1 commit into
gabrielmusat/add-taxi-iceberg-datasetfrom
gabrielmusat/add-empty-iceberg-crate

Conversation

@gabotechs

@gabotechs gabotechs commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Introduces the empty datafusion-distributed-iceberg crate, its dependency set, and the corresponding lockfile updates.

This is the first layer of the Iceberg integration stack. The implementation follows in #595.

@gabotechs
gabotechs marked this pull request as ready for review August 9, 2026 13:45

@shinzoxD shinzoxD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new workspace crate is not covered by the current CI commands. Because the workspace root is itself a package and there is no default-members entry, cargo metadata --no-deps reports only datafusion-distributed as a default member. The workflow runs cargo build, cargo test --features integration, and cargo clippy --all-targets --all-features without --workspace or -p datafusion-distributed-iceberg, so the green checks do not compile or lint this crate (or validate its dependency/feature combination); only cargo fmt --all reaches it.

Please add explicit CI coverage for datafusion-distributed-iceberg (or include it in the intended default-member/workspace commands) as part of introducing the crate. I also attempted the missing cargo check -p datafusion-distributed-iceberg --all-targets locally, but its fresh dependency build exceeded a three-minute bounded run, so I am not claiming a local compiler result.

@gabotechs gabotechs changed the title Add Iceberg crate dependencies [Iceberg] Add Iceberg crate dependencies Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants