[Iceberg] Commit taxi iceberg dataset - #594
Open
gabotechs wants to merge 1 commit into
Open
Conversation
shinzoxD
suggested changes
Aug 9, 2026
shinzoxD
left a comment
Contributor
There was a problem hiding this comment.
One factual fixture/documentation mismatch needs correction: I inspected all 91 Parquet column chunks (7 files × 13 columns) with PyArrow 25; each reports UNCOMPRESSED and parquet-rs 58.3.0, while the README calls the files Zstandard-compressed and shows COMPRESSION zstd. Please either regenerate the committed files with ZSTD or update the README/extraction description to match the actual fixture. The other integrity checks passed: 175,000 rows total, 25,000 per date partition, positive-value filters, field IDs 1–13, and Iceberg v2 manifest paths/counts/sizes all agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits an Iceberg dataset to LFS for future testing. This is the same approach we use today for parquet files, but for Iceberg in this case, the upper PR in this stack will use it for integration testing.
Stack created with GitHub Stacks CLI • Give Feedback 💬