bump threshold to 0.6 for production - #6594
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the production configuration to increase the rollout percentage for a specific feature flag. This change is part of a planned phased deployment to expand the availability of the SPANNER_EMBEDDING_THRESHOLD feature to 50% of production traffic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Please conduct a careful review before merging this production change & coordinate with the oncaller. Things to check before approving:
|
There was a problem hiding this comment.
Code Review
This pull request increases the rollout percentage for the use_config_threshold_for_spanner_embedding feature flag from 20% to 50% in production. The reviewer noted that because the feature flag evaluation uses non-sticky random assignment, a fractional rollout percentage can lead to inconsistent behavior if evaluated multiple times within a single request. They suggest implementing sticky cohort assignment or caching the flag's value per request context.
Bumping to fully using threshold of 0.6 after discussed offline with Dave and Gabe