Skip to content

bump threshold to 0.6 for production - #6594

Merged
shixiao-coder merged 3 commits into
datacommonsorg:masterfrom
shixiao-coder:50p-rolling-threshold-to-0.6
Aug 19, 2026
Merged

bump threshold to 0.6 for production#6594
shixiao-coder merged 3 commits into
datacommonsorg:masterfrom
shixiao-coder:50p-rolling-threshold-to-0.6

Conversation

@shixiao-coder

@shixiao-coder shixiao-coder commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Bumping to fully using threshold of 0.6 after discussed offline with Dave and Gabe

@shixiao-coder
shixiao-coder requested a review from a team as a code owner August 18, 2026 19:24
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the production configuration to increase the rollout percentage for a specific feature flag. This change is part of a planned phased deployment to expand the availability of the SPANNER_EMBEDDING_THRESHOLD feature to 50% of production traffic.

Highlights

  • Feature Flag Rollout: Increased the rollout percentage for the SPANNER_EMBEDDING_THRESHOLD feature flag from 20% to 50% in the production environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown

⚠️ PRODUCTION FEATURE FLAG CHANGE — REVIEW CHECKLIST

Please conduct a careful review before merging this production change & coordinate with the oncaller.
Merging this PR will trigger a rolling restart of all Kubernetes pods in production.

Things to check before approving:

  • Staging Validated: Have these exact flag changes been tested and verified in staging?
  • Cache Invalidation: If API responses change, remember to clear the Redis cache after merging.
  • Time Window: Ensure updates occur during global working hours; request lead approval for Friday–Sunday updates.
  • Oncall Communication: Please additionally announce this update on the oncall thread.
  • Type Safety: Verify that flag value types match what the server binary expects.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the rollout percentage for the use_config_threshold_for_spanner_embedding feature flag from 20% to 50% in production. The reviewer noted that because the feature flag evaluation uses non-sticky random assignment, a fractional rollout percentage can lead to inconsistent behavior if evaluated multiple times within a single request. They suggest implementing sticky cohort assignment or caching the flag's value per request context.

Comment thread server/config/feature_flag_configs/production.json Outdated
@shixiao-coder
shixiao-coder requested a review from gmechali August 19, 2026 17:38

@gmechali gmechali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xiao!

@shixiao-coder shixiao-coder changed the title bump threshold to 0.6 for 50 percent of production bump threshold to 0.6 for production Aug 19, 2026
@shixiao-coder
shixiao-coder merged commit f86fa1d into datacommonsorg:master Aug 19, 2026
17 of 18 checks passed
@shixiao-coder
shixiao-coder deleted the 50p-rolling-threshold-to-0.6 branch August 19, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants