Skip to content

Update redirects README to reflect current behavior. #6593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nick-nlb merged 2 commits into from
Aug 18, 2026
Merged

Update redirects README to reflect current behavior. #6593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a491496
Update redirects README to reflect current behavior in terms of bucke…
nick-nlb Aug 18, 2026
769f30d
Merge branch 'master' into redirect-readme-copy
nick-nlb Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/routes/redirects/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The `redirects.json` file in this directory is stored in a GCS bucket and
read by the production Flask server on each redirection call (to achieve
immediate update without rollout/restart).
read by the Flask server on server start. A rollout/restart is required

@gmechali gmechali Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember now - I may have changed the behavior.

this used to always read from GCS which felt extremely wasteful. So changed it so that it loads on startup. I just didnt fix this documentation :)

Thank you!

@nick-nlb nick-nlb Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new behavior is much better, especially given how rarely we actually change these redirects!

for these changes to be read and take effect in production.

Redirects can be used at datacommons.org/link/<REDIRECT-NAME>

Expand Down
Loading