Facet updates on data-tile to make sure all the facets are listed - #438
Open
miss-o-soup wants to merge 8 commits into
Open
Facet updates on data-tile to make sure all the facets are listed#438miss-o-soup wants to merge 8 commits into
miss-o-soup wants to merge 8 commits into
Conversation
Frontend & UI Style Updates Complete Facet Listing in Tile Tables (render_result_html.ts): Replaced single-facet rendering (facets[0]) with a full loop over all available dataset facets per statistical variable (facets.map(formatFacetBlock)). Formatted each facet line-by-line (source, dateRange, measurementMethod, unit) separated by clean <br><br> paragraph breaks inside the table cell.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the HTML rendering logic to support displaying multiple facets per variable and restructures the layout of insights and notes, placing insights at the top of the card without headers or bullet points. The review feedback highlights two key improvements: handling cases where the earliest and latest dates are identical to avoid redundant date ranges (e.g., '2020 – 2020'), and escaping pipe characters in facet details to prevent them from breaking the markdown table structure.
Missing UI updates for the insights card
…e facet display in the table card.
…r in footer styles.
…wn table breakage
nick-nlb
marked this pull request as ready for review
August 18, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Facet updates on data-tile to make sure all the facets are listed
Frontend & UI Style Updates related
Complete Facet Listing in Tile Tables (render_result_html.ts):
Replaced single-facet rendering (facets[0]) with a full loop over all available dataset facets per statistical variable (facets.map(formatFacetBlock)).
Formatted each facet line-by-line (source, dateRange, measurementMethod, unit) separated by clean paragraph breaks inside the table cell.
NOTE: It might be that these updates requires merging first the updates to use our new MCP tools like get metadata, this is in a separate-upcoming PR
Before

After

Reorganized Card Hierarchy & Titles (sync_store.ts & render_result_html.ts):
Card Titles: Removed • Notes suffix from card headers and updated title derivation to Relevant insights on ${topicTitle}.
Insights Positioned First: Moved insight paragraphs to the very top of both single-place notes cards and cross-place comparison cards.
Header & Bullet Removal: Removed sub-headers ("### Relevant insights" / "### Comparative insights") and bullet point markers (- / Title: ).
"About this data" Positioned Below: Placed ### About this data (coverage & caveats) below the insights section.
Typography & Spacing Refinements (text.module.scss):
Improved footer with follow up questions header:
Changed header from “About this data” to simply “Notes”
Changed '### About this data\n\n' to '### Notes\n\n' for both single-place notes cards and cross-place comparison cards.
Before

After

Note the insights at the top should be improved and be presented more as a paragraph, will do so in a future PR. This one is just for the layout of the card content itself.