Update logic to fetch rollback version - #731
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the rollback mechanism to revert imports to the last successful version by querying the version history with a "SUCCESS" status. However, this change removes the context of the active version before the rollback, returning None for the failed version. The reviewer suggests retrieving the current version using spanner_client.get_import_latest_version to preserve this useful context in logs and API responses.
vish-cs
force-pushed
the
version
branch
2 times, most recently
from
August 20, 2026 11:17
84c0c77 to
2c79e7d
Compare
rohitkumarbhagat
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently get the list of versions from the ImportVersionHistoryTable and use the version not matching the current version. Instead, this PR changes the logic to use the last version with status SUCCESS from ImportVersionHistory table for rollback.