Fix deletion handling in aggregations - #730
Conversation
Not up to standards ⛔🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable timeout for Spanner deletion operations to prevent 1-hour timeouts during partitioned DML executions, and simplifies the SQL query used to delete linked edges. The review feedback highlights two key improvements: avoiding fragile access to private Spanner client attributes by utilizing the public timeout parameter in execute_partitioned_dml, and simplifying the argument retrieval in main.py by directly accessing args.deletion_timeout instead of using getattr.
35fe39a to
5e38ecf
Compare
Updated deletion query in aggregation which timed out for Place import.