Skip to content

Drop the legacy numeric _type_tag (arm index) layout #1949

Description

@dmpetrov

Follow-up to #1824 — valid only once that PR is merged.

#1824 changes the Optional[DataModel] / union discriminator _type_tag from an arm
index to the arm name, and keeps reading the old layout behind a FutureWarning. This
issue removes that path.

Do: in src/datachain/lib/data_model.py drop _arm_for_index_tag, _warn_index_tag
and LEGACY_PRESENT_TAG, so arm_for_tag() raises OutdatedDatasetFormatError for any
tag that is not an arm name. Update the index-tag tests in tests/unit/lib/test_union_types.py.

Note: only reading was ever supported. The column type changed Int64 → String,
so a legacy dataset mixed with a new one (union(), joins) already fails on ClickHouse.
Removal just turns a silent read into a clear error.

Target: first minor release after #1824 ships.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions