Skip to content

Use constants instead of hardcoding strings #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pietern merged 1 commit into from
May 24, 2023
Merged

Use constants instead of hardcoding strings #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions internal/workspace_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ func TestAccWorkspaceIntegration(t *testing.T) {
// Import the test notebook
err := w.Workspace.Import(ctx, workspace.Import{
Path: notebook,
Format: "SOURCE",
Language: "PYTHON",
Format: workspace.ExportFormatSource,
Language: workspace.LanguagePython,
Content: base64.StdEncoding.EncodeToString([]byte("# Databricks notebook source\nprint('hello from job')")),
Overwrite: true,
})
Expand All @@ -47,14 +47,14 @@ func TestAccWorkspaceIntegration(t *testing.T) {
// Get test notebook status
getStatusResponse, err := w.Workspace.GetStatusByPath(ctx, notebook)
require.NoError(t, err)
assert.True(t, getStatusResponse.Language == "PYTHON")
assert.True(t, getStatusResponse.Language == workspace.LanguagePython)
assert.True(t, getStatusResponse.Path == notebook)
assert.True(t, string(getStatusResponse.ObjectType) == "NOTEBOOK")
assert.True(t, getStatusResponse.ObjectType == workspace.ObjectTypeNotebook)

// Export the notebook and assert the contents
exportResponse, err := w.Workspace.Export(ctx, workspace.ExportRequest{
DirectDownload: false,
Format: "SOURCE",
Format: workspace.ExportFormatSource,
Path: notebook,
})
require.NoError(t, err)
Expand All @@ -81,8 +81,8 @@ func TestAccWorkspaceRecursiveListNoTranspile(t *testing.T) {
// Import the test notebook
err := w.Workspace.Import(ctx, workspace.Import{
Path: notebook,
Format: "SOURCE",
Language: "PYTHON",
Format: workspace.ExportFormatSource,
Language: workspace.LanguagePython,
Content: base64.StdEncoding.EncodeToString([]byte("# Databricks notebook source\nprint('hello from job')")),
Overwrite: true,
})
Expand Down