Rename reflect.Ptr to reflect.Pointer#5303
Closed
pietern wants to merge 2 commits into
Closed
Conversation
reflect.Ptr is kept as a legacy alias for reflect.Pointer; reflect.Pointer is the canonical name and matches the Kind constant name elsewhere. This commit only adds the rule, so lint will fail on existing call sites. The follow-up commit applies the rename. Co-authored-by: Isaac
reflect.Ptr is a legacy alias for reflect.Pointer; the canonical name matches the rest of the Kind constants. Lint added in the previous commit now passes. Co-authored-by: Isaac
Contributor
Approval status: pending
|
Contributor
Author
|
This is done automatically by a newer version of golangci-lint. That's better than a custom rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #5302.
reflect.Ptris a legacy alias forreflect.Pointer. Renames the 13 call sites and adds a forbidigo rule to keep it that way.This pull request and its description were written by Isaac.