fix: keep quarantine database when table name is unqualified - #153
Merged
Merged
Conversation
Clearing database whenever table was set dropped an unqualified quarantine name into the pipeline default schema. Keep database unless table is already catalog.schema.table.
rederik76
deleted the
fix/quarantine-unqualified-table-keeps-database
branch
September 7, 2026 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quarantine_target_details.databasewhentableis an unqualified name so TargetFactory can qualify it once.databasewhentableis alreadycatalog.schema.table, to avoid double-qualifying.Note - ideally we'd prevent fully qualified names in the table property and force use of database and optionally the table name (unqualified) but this may break things for existing deployments.
Closes #152
Test plan
pytest tests/unit/dataflow/test_quarantine_logic.py(13 passed)database+ unqualifiedtablecreates the quarantine table in the configured catalog/schema, not the pipeline default