test(engine): pin the retired Default-alphabet heal (DasherCore#88) - #89
Merged
Merged
Conversation
The live 'no text goes into the output area' report traced to AlphabetID='Default' in the user's settings — the emergency a-z fallback, registered unconditionally and selectable, which is structurally dead (drives commit nothing). DasherCore#88 retires the registration + heals the id at realize; this pins both through the bridge: healed alphabet != 'Default' AND the canonical drive produces output. Submodule pinned to the fix branch — re-pin to the tagged release once merged. ctest 3/3. Signed-off-by: will wade <willwade@gmail.com>
Signed-off-by: will wade <willwade@gmail.com>
Signed-off-by: will wade <willwade@gmail.com>
Contributor
Author
|
Submodule re-pinned to the DasherCore#88 squash ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to dasher-project/DasherCore#88 — the live 'no text goes into the output area' report, root-caused to the dead emergency alphabet, fixed engine-side. This pins the heal + drive through the GTK bridge surface and pins the submodule to the fix branch (re-pin to the tagged release once DasherCore#88 merges). Users hit pre-merge: switch the alphabet picker off 'Default'. ctest 3/3. DCO signed.
The PR appears safe to merge, with no actionable new defects identified.
Summary
DasherBridge.Reviews (3) · Last reviewed commit: "chore: DasherCore #88 merged (a0f5da6) —..."