Fix issues discovered when using web server device in flutter tools#1588
Merged
annagrin merged 9 commits intodart-lang:masterfrom Apr 19, 2022
Merged
Conversation
added 3 commits
April 18, 2022 16:04
elliette
reviewed
Apr 19, 2022
elliette
reviewed
Apr 19, 2022
elliette
reviewed
Apr 19, 2022
elliette
approved these changes
Apr 19, 2022
Contributor
elliette
left a comment
elliette
left a comment
There was a problem hiding this comment.
LGTM with few small changes
nshahan
approved these changes
Apr 19, 2022
grouma
approved these changes
Apr 19, 2022
added 3 commits
April 19, 2022 14:28
…grin/webdev into annagrin/fix_breakpoints_web_server
Member
|
@annagrin we need this published before we can roll to Flutter, right? |
Contributor
Author
|
@mit-mit that's right, it has been published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for resolving
dart:uris is incomplete and slows downs integration due to dependency on an internal library.package:_fe_analyzer_sharedand incorrect support for resolvingdart:uris.Flutter tool crashes in dev_handler
Bogus warning about unresolved
dart:web_sqllibrary that is no longer used.dart:web_sqlSDK library from the SDK libraries list.Broken breakpoints due to script information being cleared on page (re)load.
Page.frameStartedLoadingandDebugger.globalObjectCleared.Webkit debugger has the correct behavior since the scripts are not re-added on page reload or hot restart.
Closes: #1581
Closes: #1575
Closes: #1579
Helps: flutter/flutter#101639
Helps: flutter/flutter#101224
Helps: flutter/flutter#102159