Repository navigation
feat: credit Darkroom Engineering Incubator in the README and About window (INC-984) - #592
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Programa now credits Darkroom Engineering Incubator. The README shows "A sidequest by Darkroom Engineering Incubator" under the header badges, and the About window shows the same line as a link to https://darkroom.engineering/incubator, below the Docs, GitHub and Licenses buttons.
Summary
Sources/ProgramaApp.swift: aLinkinAboutPanelView, captioned like the rest of the panel's small print.Resources/Localizable.xcstrings: newabout.incubatorCreditkey. The Japanese value keeps the English text, since the credit wording is fixed.README.md: one centered line under the badges.Linear: INC-984
Test plan
./scripts/reload.sh --tag inc-984-credit-line), open Programa > About Programa, and check the line appears and opens the incubator page.Screenshots: before/after needed for the About window.