Repository navigation
fix: explain the ignored-files worktree blocker in the CLI and socket API (INC-508) - #588
Merged
Merged
Conversation
…manual clean rules (INC-508)
…factory (INC-508)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes INC-508. When a worktree can't be cleaned because it holds ignored files, the CLI and socket API now give a readable reason instead of the raw
ignored_filescode.storage.scanalso judges removability by the same manual-clean rules the Storage panel uses, so the two agree.docs/socket-api.md, since the v2 contract has no result schemas.Left as is: the Storage panel ignores the 24-hour recent-use window that
storage scanand--dry-runapply. That predates this change. Aligning the scan with the panel would make it disagree with--dry-run.Verified: a Codex review came back clean. The build first runs in this PR's CI, because the worktree had no ghostty submodule.