Skip to content

fix(pubsub): use the stable bulk publish endpoint on an edge runtime - #914

Closed
javier-aliaga wants to merge 2 commits into
dapr:mainfrom
javier-aliaga:fix/bulk-publish-edge-version
Closed

javier-aliaga wants to merge 2 commits into
dapr:mainfrom
javier-aliaga:fix/bulk-publish-edge-version

Conversation

@javier-aliaga

Copy link
Copy Markdown
Contributor

Description

Since #856, publishBulk picks the bulk publish endpoint from the sidecar's runtimeVersion. A daprd built without a release version reports edge, which the version regex does not match, so every bulk publish fails without publishing:

ERROR [HTTPClient, PubSub] Failure publishing bulk messages: Error: Unable to determine Dapr runtime version from metadata: 'edge'.

This breaks the JS SDK job of dapr/dapr's nightly dapr-test-sdk, which runs the SDK e2e tests against daprd built from dapr master: failing job. Three client.test.ts bulk publish tests fail.

An edge build comes from the latest source, so this PR maps it to the stable v1.0 endpoint. A missing or otherwise unparseable version still refuses to publish, as should not publish when runtime metadata has no usable version expects.

Issue reference

None, CI failure.

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

should use the stable v1.0 endpoint on an edge runtime fails without the change and passes with it. npm run test:unit:http passes (45 tests).

A daprd built without a release version reports runtimeVersion "edge", which the version check could not parse, so publishBulk failed without publishing. An edge build comes from the latest source, so it serves the stable v1.0 endpoint.

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga
javier-aliaga requested review from a team as code owners October 20, 2026 07:37
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.83%. Comparing base (d1bf38a) to head (e1ef8d1).
⚠️ Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
src/implementation/Client/HTTPClient/pubsub.ts 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d1bf38a) and HEAD (e1ef8d1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d1bf38a) HEAD (e1ef8d1)
1 0
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #914       +/-   ##
============================================
- Coverage   100.00%   51.83%   -48.17%     
============================================
  Files            1      141      +140     
  Lines            6     4526     +4520     
  Branches         1      888      +887     
============================================
+ Hits             6     2346     +2340     
- Misses           0     2022     +2022     
- Partials         0      158      +158     
Flag Coverage Δ
e2e 23.88% <0.00%> (?)
unit 46.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WhitWaldo

Copy link
Copy Markdown
Contributor

Superseded by #914

@WhitWaldo WhitWaldo closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants