Repository navigation
fix(pubsub): use the stable bulk publish endpoint on an edge runtime - #914
Closed
javier-aliaga wants to merge 2 commits into
Closed
javier-aliaga wants to merge 2 commits into
javier-aliaga wants to merge 2 commits into
Conversation
A daprd built without a release version reports runtimeVersion "edge", which the version check could not parse, so publishBulk failed without publishing. An edge build comes from the latest source, so it serves the stable v1.0 endpoint. Signed-off-by: Javier Aliaga <javier@diagrid.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
============================================
- Coverage 100.00% 51.83% -48.17%
============================================
Files 1 141 +140
Lines 6 4526 +4520
Branches 1 888 +887
============================================
+ Hits 6 2346 +2340
- Misses 0 2022 +2022
- Partials 0 158 +158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 of 3 tasks
Contributor
|
Superseded by #914 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #856,
publishBulkpicks the bulk publish endpoint from the sidecar'sruntimeVersion. A daprd built without a release version reportsedge, which the version regex does not match, so every bulk publish fails without publishing:This breaks the JS SDK job of dapr/dapr's nightly
dapr-test-sdk, which runs the SDK e2e tests against daprd built from dapr master: failing job. Threeclient.test.tsbulk publish tests fail.An
edgebuild comes from the latest source, so this PR maps it to the stablev1.0endpoint. A missing or otherwise unparseable version still refuses to publish, asshould not publish when runtime metadata has no usable versionexpects.Issue reference
None, CI failure.
Checklist
should use the stable v1.0 endpoint on an edge runtimefails without the change and passes with it.npm run test:unit:httppasses (45 tests).