Skip to content

bug: Actors.Next - Cancellation of one caller doesn't strand accepted turns - #1936

Merged
WhitWaldo merged 1 commit into
masterfrom
actors-next-cancellation-bug
Oct 18, 2026
Merged

WhitWaldo merged 1 commit into
masterfrom
actors-next-cancellation-bug

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

Fixed scheduling bug so cancellation of one caller cannot strand accepted turns or mask the actor's original exception. Inline turn handoff and post-enqueue scheduling not run independently of caller cancellation and each turn retains its own cancellation token.

Thank you @olitomlinson for surfacing the bug in Dapr.Actors that led to discovering this issue.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…pted turns or mask the actor's original exception. Inline turn handoff and post-enqueue scheduling not run independently of caller cancellation and each turn retains its own cancellation token.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.19 milestone Oct 18, 2026
@WhitWaldo WhitWaldo self-assigned this Oct 18, 2026
@WhitWaldo
WhitWaldo requested review from a team as code owners October 18, 2026 02:47
@codecov

codecov Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.18%. Comparing base (1b422ec) to head (ab3ea66).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1936      +/-   ##
==========================================
- Coverage   65.19%   65.18%   -0.01%     
==========================================
  Files         370      370              
  Lines       10766    10766              
  Branches     1262     1262              
==========================================
- Hits         7019     7018       -1     
- Misses       3408     3410       +2     
+ Partials      339      338       -1     
Flag Coverage Δ
net10.0 65.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WhitWaldo WhitWaldo added the kind/bug Something isn't working label Oct 18, 2026
@WhitWaldo
WhitWaldo merged commit b0da611 into master Oct 18, 2026
1027 of 1033 checks passed
@WhitWaldo
WhitWaldo deleted the actors-next-cancellation-bug branch October 18, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/actor kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant