Repository navigation
fix(welcome): epilepc note showed a raw {date} and a past shutdown date - #254
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while refreshing the docs (#253). The dashboard welcome card for people who migrated from epilepc had two problems in its read-only note:
WelcomeCard.sveltepasseddateto the body key, which has no placeholder.$tonly replaces the params it is given, so every migrated user saw a literal{date}, in all four locales.Fix: the title now says epilepc stays readable until at least the end of 2026 (de/en/fr/it, Swiss German without ß). The stray param is gone. The body ("Until then your old account stays open for reads and downloads…") reads correctly under the new title.
Testing
WelcomeCard.readonly.test.ts: in every locale, no unfilled{placeholder}and no 2026-10-31; the component passes no params to these keys. All 5 tests fail on the old code.registrationSource: 'migrate'): the text contains 2026 and no{date}.