Skip to content

fix(deploy): wizard exits silently before the confirm prompt on a clean release [skip changelog] - #252

Merged
danileau merged 1 commit into
mainfrom
fix/wizard-clean-release-exit
Nov 12, 2026
Merged

danileau merged 1 commit into
mainfrom
fix/wizard-clean-release-exit

Conversation

@danileau

Copy link
Copy Markdown
Owner

The deploy wizard exited silently right after "Deploy to PRODUCTION", before the [y/N] prompt. It hit while deploying 1.5.3 (a52948e). The y the operator typed went to their shell, not the wizard. No tag was pushed.

Cause

release_state() ended with [ -n "$out" ] && { …; }. When the commit is in a clean, tagged release, release-state.sh prints nothing, and the && list returns 1 as the function's last command. Under set -euo pipefail, the wizard then exits with status 1 and no message.

This was the first deploy with a clean release state: v1.5.3 was tagged before the deploy. Earlier deploys always had a warning (pending fragments or an untagged version), so out was never empty.

Fix

Use an if instead of the && list. I checked the wizard's other [ … ] && … lines. They are top-level statements or not the last command in a loop, so set -e doesn't fire on them.

Testing

I extracted release_state and ran it under set -euo pipefail:

  • Clean commit (a52948e) with the real release-state.sh: the old code exits 1; the fixed code continues to the prompt.
  • With a stub that prints a warning, the warning still prints and the function continues.
  • scripts/test-release-state.sh: 6 passed. bash -n OK.
  • The operator ran the patched wizard locally: it reached the prompt.

Operator tooling only, so [skip changelog].

@danileau
danileau enabled auto-merge (squash) November 12, 2026 13:32
@danileau
danileau disabled auto-merge November 12, 2026 13:32
@danileau
danileau merged commit cb8bd5c into main Nov 12, 2026
4 checks passed
@danileau
danileau deleted the fix/wizard-clean-release-exit branch November 12, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant