Repository navigation
fix(deploy): wizard exits silently before the confirm prompt on a clean release [skip changelog] - #252
Merged
Conversation
… release [skip changelog]
danileau
enabled auto-merge (squash)
November 12, 2026 13:32
danileau
disabled auto-merge
November 12, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy wizard exited silently right after "Deploy to PRODUCTION", before the
[y/N]prompt. It hit while deploying 1.5.3 (a52948e). Theythe operator typed went to their shell, not the wizard. No tag was pushed.Cause
release_state()ended with[ -n "$out" ] && { …; }. When the commit is in a clean, tagged release,release-state.shprints nothing, and the&&list returns 1 as the function's last command. Underset -euo pipefail, the wizard then exits with status 1 and no message.This was the first deploy with a clean release state: v1.5.3 was tagged before the deploy. Earlier deploys always had a warning (pending fragments or an untagged version), so
outwas never empty.Fix
Use an
ifinstead of the&&list. I checked the wizard's other[ … ] && …lines. They are top-level statements or not the last command in a loop, soset -edoesn't fire on them.Testing
I extracted
release_stateand ran it underset -euo pipefail:release-state.sh: the old code exits 1; the fixed code continues to the prompt.scripts/test-release-state.sh: 6 passed.bash -nOK.Operator tooling only, so
[skip changelog].