Skip to content

Allow bounded fallback cycles and keep provider save errors visible - #179

Merged
danielmaier42 merged 3 commits into
mainfrom
feature/bounded-fallback-cycles
Nov 13, 2026
Merged

danielmaier42 merged 3 commits into
mainfrom
feature/bounded-fallback-cycles

Conversation

@danielmaier42

Copy link
Copy Markdown
Owner

Provider settings currently reject cyclic fallback chains, so a setup such as Claude → Codex → Claude cannot be saved. This allows cycles between different configured providers while retaining the resolver's visited-provider guard. When every reachable provider is blocked, the task stays queued and runs once an account becomes available. Self-reference and missing targets remain invalid.

Provider edit failures now stay in the fixed dialog footer beside the save controls, rather than below the scrolled form. README and plan describe the behavior. The downgrade floor moves to 2.1.4 because older releases reject the cyclic configurations this version can save. Pool selection behavior is unchanged.

Validation:

  • Build and vet with CI Go 1.26.10
  • Full Go race suite
  • CI golangci-lint v2.12.2
  • Web typecheck, lint, build and all 296 tests
  • Regression fail-before/pass-after for cyclic config persistence, provider edit API and scheduler recovery, plus save-error placement
  • Independent Sol Medium review, no remaining findings
  • Bundled Chromium exercise of failed save at desktop and 430px width, confirming error and Save stay visible after scrolling

UI checks used a read-only snapshot of provider names with intercepted writes and a disposable failure fixture. No installed app, live configuration or queued jobs were changed. Website and shared interface documentation need no matching change because the app's public interface and pool semantics are unchanged. Desktop and narrow screenshots accompany the delivery in the owning chat.

@danielmaier42
danielmaier42 merged commit 48f8b9c into main Nov 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant