Repository navigation
Allow bounded fallback cycles and keep provider save errors visible - #179
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider settings currently reject cyclic fallback chains, so a setup such as Claude → Codex → Claude cannot be saved. This allows cycles between different configured providers while retaining the resolver's visited-provider guard. When every reachable provider is blocked, the task stays queued and runs once an account becomes available. Self-reference and missing targets remain invalid.
Provider edit failures now stay in the fixed dialog footer beside the save controls, rather than below the scrolled form. README and plan describe the behavior. The downgrade floor moves to 2.1.4 because older releases reject the cyclic configurations this version can save. Pool selection behavior is unchanged.
Validation:
UI checks used a read-only snapshot of provider names with intercepted writes and a disposable failure fixture. No installed app, live configuration or queued jobs were changed. Website and shared interface documentation need no matching change because the app's public interface and pool semantics are unchanged. Desktop and narrow screenshots accompany the delivery in the owning chat.