Skip to content
This repository was archived by the owner on May 10, 2023. It is now read-only.

Fix the extension on everyone's but Daniel's computer - #4

Closed
adamziel wants to merge 11 commits into
trunkfrom
blank-slate
Closed

adamziel wants to merge 11 commits into
trunkfrom
blank-slate

Conversation

@adamziel

@adamziel adamziel commented Apr 3, 2023 •

Copy link
Copy Markdown
Collaborator

Solves #1

  • Removes the build pipeline which hardcoded the paths.
  • Abstract server.js from the extension.js
  • Remove the VS code tab, only open the playground in the actual web browser

May not need to merge this PR – I'd like to move this extension over to the canonical WordPress Playground repo

cc @dmsnell

@danielbachhuber

Copy link
Copy Markdown
Owner

I'd like to move this extension over to the canonical WordPress Playground repo

@adamziel I'm fine with this, whenever you might want to take it on.

@jonathanbossenger

jonathanbossenger commented Apr 4, 2023 •

Copy link
Copy Markdown

I tested this update today and it works!

@danielbachhuber

Copy link
Copy Markdown
Owner

Remove the VS code tab, only open the playground in the actual web browser

@adamziel I liked launching in VS Code for the demo effect. It was a little bit jarring to load directly in the browser.

What do you think about opening in VS Code by default, and having a button that says "Open in browser" within that pane?

@dmsnell

dmsnell commented May 1, 2023

Copy link
Copy Markdown

@danielbachhuber the demo effect might be nice, but I've found it practically frustrating because of the lack of browser dev tools and navigation support, opening new tabs, etc…

I'd rather keep the default to the browser, but I don't see why we couldn't also include a second command to launch directly in VSCode.

What about opening a new browser tab to the launched WordPress do you find less appealing?

@danielbachhuber

Copy link
Copy Markdown
Owner

What about opening a new browser tab to the launched WordPress do you find less appealing?

It wasn't the behavior I expected. Additionally, there wasn't an obvious indication that the website I redirected to had anything to do with my codebase.

@dmsnell

dmsnell commented May 1, 2023

Copy link
Copy Markdown

maybe two commands would work best then: "Launch playground" and "Launch playground (inside VSCode)"

the in-VSCode environment is almost unusable from a development perspective because of the limitations of that browser (as I noted above)

@adamziel

adamziel commented May 5, 2023

Copy link
Copy Markdown
Collaborator Author

I like launching inside VS code to show that it works, but I would absolutely hate using that for actual development. The browser has amazing developer tools and plugins and it would be a shame to prevent people from using those. Two execution modes sound like a good compromise.

@danielbachhuber

Copy link
Copy Markdown
Owner

Two execution modes sound like a good compromise.

I have an idea on how to do this.

adamziel added a commit to WordPress/wordpress-playground that referenced this pull request May 10, 2023
Ports the [VS code extension](danielbachhuber/wordpress-playground-vscode#4) into this repository, sets up the build pipeline, and adds some UI affordances. This is built on top of wp-now.
@adamziel

adamziel commented May 10, 2023 •

Copy link
Copy Markdown
Collaborator Author

This is now ported to WordPress Playground repo – this repo can be deleted.

WordPress/wordpress-playground#288

@adamziel adamziel closed this May 10, 2023
@danielbachhuber

Copy link
Copy Markdown
Owner

@adamziel Thanks! I will archive the repo for historical purposes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants