Replace BitAPI with a LuaJ implementation of bit32#298
Open
SquidDev wants to merge 2 commits intodan200:masterfrom
Open
Replace BitAPI with a LuaJ implementation of bit32#298SquidDev wants to merge 2 commits intodan200:masterfrom
SquidDev wants to merge 2 commits intodan200:masterfrom
Conversation
SquidDev
force-pushed
the
feature/luaj-bit32
branch
from
bb804c9 to
084bbe8
Compare
Owner
|
Idea seems good. How about moving this into our actual LuaJ sources? |
Contributor
Author
|
Sure. Would you also like me to rebuild the LuaJ jar then? |
SquidDev
pushed a commit
to SquidDev/urn
that referenced
this pull request
Mar 31, 2018
…mputerCraft ComputerCraft has an incomplete bit32 API. bit32.lib.lua implemented ALL the functions in software, but only if bit32 didn't exist entirely, which does on CC. This means bit32.extract and bit32.replace weren't implemented in software on CC. This commit fixes the issue. See dan200/ComputerCraft#298
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…luaj-bit32 Replace BitAPI with a LuaJ implementation of bit32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes CC's
bitlibrary and adds LuaJ's implementation ofbit32, stubbing the originalbitlibrary. This has several advantages:bit32functions are significantly faster - my rather ad-hoc profiling shows a gain of somewhere between 1.5x and 2x.bit32now accepts variadic arguments and implementsextractandreplace.I realise you lose the nice abstraction of
ILuaAPI, but I don't feel that is a great loss -bitwon't be needed should we ever switch to Lua 5.2/5.3 anyway.I'm happy to move this to the LuaJ directory and rebuild the LuaJ jar should you want.